Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes shower curtains not showing above mobs. #1796

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

TerryTehCoder
Copy link
Contributor

@TerryTehCoder TerryTehCoder commented Sep 2, 2024

About the Pull Request

Adjusts the plane of shower curtains to 2 (Mob Plane) when closed so that their layer actually works and puts them above Carbons when closed.

image

Why It's Good For The Game

You would not Stand on your shower curtains at home... why would you do it at work?

Resolves #1613, needs review from someone with more experience using planes and layers to verify this is acceptable usage.

Changelog

🆑
Fixed: Shower curtains now show above mobs when closed, rather than the other way around with mobs standing on the curtains.
/:cl:

@github-actions github-actions bot added the Code Touched Code label Sep 2, 2024
Copy link
Contributor

@checkraisefold checkraisefold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is acceptable though I foresee unknown bugs happening down the line that may need to be fixed. SHOULDN'T happen looking at the layers
It's ridiculous that we have separate planes anyway this shit is so stupid, everyone else has 1 game-wide plane

@TerryTehCoder
Copy link
Contributor Author

What baffles me the most is that there was no major discrepancies between this file and bays version of curtain code. So either they handle it somewhere else, or curtains are just not something they ever fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Touched Code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shower Curtains underneath player mobs rather than over player mobs
2 participants