Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: GamePad controller inputs #234

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

Thomaltarix
Copy link
Collaborator

@Thomaltarix Thomaltarix commented Jun 21, 2024

I bound all the keyboards inputs to GamePad inputs.

Now you can do everything you do with a keyboard with a GamePad, except closing the window ('coz it segfault).

Note

I don't know if every type of GamePad is accepted by raylib or not

all inputs are done except the window closing
@Thomaltarix Thomaltarix added the enhancement New feature or request label Jun 21, 2024
@Thomaltarix Thomaltarix self-assigned this Jun 21, 2024
@Thomaltarix Thomaltarix linked an issue Jun 21, 2024 that may be closed by this pull request
theophile-jr
theophile-jr previously approved these changes Jun 21, 2024
Copy link
Member

@theophile-jr theophile-jr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@mathieurobert1 mathieurobert1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it's great.
The closing segfault is because you close Raylib but some raylib's functions are called after that.
To secure the well-closing of the window, a variable _isEndGame is present in GameData to close properly the window.

@Thomaltarix Thomaltarix merged commit dd1ddbd into main Jun 21, 2024
4 checks passed
@Thomaltarix Thomaltarix deleted the feat/implement-game-controller-controls-zappy-gui branch June 21, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Game Controller controls - Zappy GUI
3 participants