Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/optimize the commands calls zappy gui #246

Closed
wants to merge 4 commits into from

Conversation

Thomaltarix
Copy link
Collaborator

With the help of @mathieurobert1, i setup the a clock for each player last ppo command call.
The ppo command is used to update the player's position.
Now, if the last ppo call last from more that 50 ticks, the Gui is sending ppo for this player to the server.
This method avoid sending ppo to the server for each tick for nothing.

@Thomaltarix Thomaltarix added the enhancement New feature or request label Jun 22, 2024
@Thomaltarix Thomaltarix linked an issue Jun 22, 2024 that may be closed by this pull request
Copy link
Collaborator

@Marius-P1 Marius-P1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick question before approving

Copy link
Collaborator

@mathieurobert1 mathieurobert1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, just wait before the @AxelF44 's pr about sending ppo when need it.

@Thomaltarix Thomaltarix requested a review from Marius-P1 June 22, 2024 14:58
Copy link
Collaborator

@Marius-P1 Marius-P1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@mathieurobert1 mathieurobert1 marked this pull request as draft June 22, 2024 20:14
@Thomaltarix Thomaltarix deleted the feat/optimize-the-commands-calls-zappy-gui branch June 23, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize the commands calls - Zappy GUI
3 participants