Feat/implement parsing of arguments zappy server #55

Njord201 · 2024-06-05T11:52:02Z

I've added parsing of the server command, with error handling and argument return.

I added all flag including -h and --help, the minimum numbers of parameter required and the string of USAGE on marco in parsing.h

I added function for display and tests

I added a function for parse the positive int utils for the parsing. And, tests.

…for return code

…os variable to pointer

Thomaltarix

I requested some things, but think it's not finished, re-request me when it's done

server/include/parsing.h

server/include/rules.h

server/tests/parsing/parse_width_tests.c

server/tests/parsing/parse_port_tests.c

server/tests/parsing/parse_width_tests.c

mathieurobert1

Check the order of includes.

server/src/parsing/arguments.c

server/src/parsing/help.c

Thomaltarix

Some changes to do

server/src/parsing/arguments.c

server/src/parsing/help.c

server/src/parsing/parse_names.c

mathieurobert1

nice.

server/src/parsing/help.c

server/src/parsing/parse_client.c

server/src/parsing/parse_frequency.c

server/src/parsing/parse_height.c

server/src/parsing/parse_names.c

server/tests/parsing/parse_height_tests.c

server/tests/parsing/parse_names_tests.c

server/tests/parsing/parse_port_tests.c

server/tests/parsing/parse_positive_int_tests.c

server/tests/parsing/parse_width_tests.c

server/tests/parsing/parse_client_tests.c

server/tests/parsing/parse_frequency_tests.c

server/tests/parsing/parse_height_tests.c

server/tests/parsing/parse_port_tests.c

server/tests/parsing/parse_positive_int_tests.c

server/tests/parsing/parse_width_tests.c

Njord201 added 9 commits June 3, 2024 19:16

feat (server): add utils macro for server parsing

54ed77a

I added all flag including -h and --help, the minimum numbers of parameter required and the string of USAGE on marco in parsing.h

chore: remove .gitkeep of include dir in server

765de77

feat (server): help flags managment

62ca39e

I added function for display and tests

feat (server, parsing): parse positive int function utils

e6f6b5e

I added a function for parse the positive int utils for the parsing. And, tests.

feat (server, parsing): parse client arg fct

6055741

feat (server, parsing): parsing structure for store the element

1d735f5

refactor: parse positive int, add a macro for return code

519a20a

refactor (server, client parser): add parsing struct, and some macro …

6c042e6

…for return code

refactor (server, parsing): client function, change the type of the p…

5fa3573

…os variable to pointer

Njord201 added enhancement New feature or request server labels Jun 5, 2024

Njord201 requested review from theophile-jr and AxelF44 June 5, 2024 11:52

Njord201 self-assigned this Jun 5, 2024

Njord201 linked an issue Jun 5, 2024 that may be closed by this pull request

Implement parsing of arguments - Zappy Server #18

Closed

13 tasks

feat: argument function, for parse all the arguments wip tests

b21d727

Njord201 force-pushed the feat/implement-parsing-of-arguments-zappy-server branch from 7e4c55d to b21d727 Compare June 5, 2024 11:59

Njord201 added 5 commits June 5, 2024 14:01

feat (server, parsing): frequency flag parsing with tests

95ad05b

feat (server, parsing): height flag parsing with tests

1cb118a

feat (server, parsing): port flag parsing with tests

4a5876c

feat (server, parsing): port flag parsing with tests

7321536

feat (server, parsing): names flag parsing with tests

2ad2d45

Njord201 requested review from mathieurobert1 and Thomaltarix June 5, 2024 13:11

fix: coding style errors

848fa08

Thomaltarix requested changes Jun 5, 2024

View reviewed changes

server/include/parsing.h Outdated Show resolved Hide resolved

server/include/rules.h Outdated Show resolved Hide resolved

theophile-jr requested changes Jun 5, 2024

View reviewed changes

Njord201 marked this pull request as draft June 5, 2024 13:35

feat: parse all arguments in parse_arg

97c34e7

theophile-jr requested changes Jun 5, 2024

View reviewed changes

server/tests/parsing/parse_width_tests.c Outdated Show resolved Hide resolved

mathieurobert1 requested changes Jun 5, 2024

View reviewed changes

server/src/parsing/arguments.c Outdated Show resolved Hide resolved

server/src/parsing/help.c Outdated Show resolved Hide resolved

Thomaltarix requested changes Jun 5, 2024

View reviewed changes

server/src/parsing/arguments.c Outdated Show resolved Hide resolved

server/src/parsing/arguments.c Outdated Show resolved Hide resolved

server/src/parsing/help.c Show resolved Hide resolved

server/src/parsing/parse_names.c Outdated Show resolved Hide resolved

Njord201 added 6 commits June 5, 2024 17:23

fix: order of include in server files

76c3897

fix: check of error in arguments for parsing server

4e49116

fix: remove useless fflush

8d7ad8b

refactor: reduce a function

a7b14b9

refactor: add fflush after diplay of usage

1317493

refactor: some functions for an optimization

f78afd6

Njord201 requested review from theophile-jr, mathieurobert1 and Thomaltarix June 5, 2024 15:51

mathieurobert1 previously approved these changes Jun 5, 2024

View reviewed changes

Njord201 removed the server label Jun 5, 2024

AxelF44 requested changes Jun 5, 2024

View reviewed changes

Thomaltarix previously approved these changes Jun 5, 2024

View reviewed changes

Njord201 requested a review from AxelF44 June 5, 2024 16:47

AxelF44 requested changes Jun 5, 2024

View reviewed changes

fix: reorder the include in tests of parsing of server

5807ad4

Njord201 dismissed stale reviews from Thomaltarix and mathieurobert1 via 5807ad4 June 5, 2024 16:53

Njord201 requested review from AxelF44, mathieurobert1 and Thomaltarix June 5, 2024 16:53

mathieurobert1 approved these changes Jun 5, 2024

View reviewed changes

Thomaltarix approved these changes Jun 5, 2024

View reviewed changes

AxelF44 approved these changes Jun 5, 2024

View reviewed changes

theophile-jr approved these changes Jun 5, 2024

View reviewed changes

Njord201 merged commit a37816f into main Jun 5, 2024
4 checks passed

Njord201 deleted the feat/implement-parsing-of-arguments-zappy-server branch June 5, 2024 16:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/implement parsing of arguments zappy server #55

Feat/implement parsing of arguments zappy server #55

Njord201 commented Jun 5, 2024 •

edited

Loading

Thomaltarix left a comment

mathieurobert1 left a comment

Thomaltarix left a comment

mathieurobert1 left a comment

Feat/implement parsing of arguments zappy server #55

Feat/implement parsing of arguments zappy server #55

Conversation

Njord201 commented Jun 5, 2024 • edited Loading

Thomaltarix left a comment

Choose a reason for hiding this comment

mathieurobert1 left a comment

Choose a reason for hiding this comment

Thomaltarix left a comment

Choose a reason for hiding this comment

mathieurobert1 left a comment

Choose a reason for hiding this comment

Njord201 commented Jun 5, 2024 •

edited

Loading