Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/display players zappy gui #63

Merged
merged 10 commits into from
Jun 7, 2024
Merged

Feat/display players zappy gui #63

merged 10 commits into from
Jun 7, 2024

Conversation

mathieurobert1
Copy link
Collaborator

@mathieurobert1 mathieurobert1 commented Jun 6, 2024 •
edited
Loading

Important

This pr must be merged after this one : #59

I displayed players based on there team skin:
image

@mathieurobert1 mathieurobert1 added the enhancement New feature or request label Jun 6, 2024
@mathieurobert1 mathieurobert1 self-assigned this Jun 6, 2024
@mathieurobert1 mathieurobert1 linked an issue Jun 6, 2024 that may be closed by this pull request
Display players - Zappy GUI #58
Closed
Njord201
Njord201 reviewed Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@Njord201 Njord201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok for me, just why you remove the tests files ?

Njord201
Njord201 requested changes Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@Njord201 Njord201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do previous request, mb

Thomaltarix
Thomaltarix approved these changes Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@Thomaltarix Thomaltarix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean one, just check the kylian's requests

Thomaltarix
Thomaltarix requested changes Jun 7, 2024
View reviewed changes
Copy link
Collaborator

@Thomaltarix Thomaltarix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mainly requested the name you're using for the Player model / model path

@mathieurobert1 mathieurobert1 merged commit 34f2727 into main Jun 7, 2024
4 checks passed
@mathieurobert1 mathieurobert1 deleted the feat/display-players-zappy-gui branch June 7, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thomaltarix Thomaltarix Thomaltarix approved these changes

@Njord201 Njord201 Njord201 approved these changes

Assignees

@mathieurobert1 mathieurobert1

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display players - Zappy GUI
3 participants
@mathieurobert1 @Thomaltarix @Njord201