Some cleanup of the render and transformation code #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 2, 2021 10:34
… array and also GeoCoord and Point as coordinate parameter
Karry
approved these changes
Apr 2, 2021
|
The main change is the assertion in GenerateParallelWay which before hat a bool return value. In the end further changes seem to make sense. I would like to separate the caches from the methods that operate on them. All the transform methods could be functions that read write to streams/buffer/caches. That would likely simplify the code. Recent Clion versions now show function complexity warnings. There also a number of methods in MapPainter that have such alarm. This is another place we have to clean up before things get out of control ;-) But since I was sidetracked form hillshading I only did the obvious and quick to improve... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.