Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Player: Tooltips get cut off with long text #6336

Closed

Conversation

alexeevrevan
Copy link

@alexeevrevan alexeevrevan commented Dec 9, 2024

Tooltip bug fixed

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

closes #6331

Description

The application was inspected via devtools to find where the bug happens, I fixed it in the code afterwards. Now Tooltip pops up correctly, even with more symbols in it.

Screenshots

Before and After bugfix
before
after

Testing

Tried different options right in the browser devtools, found out that there's a css feature conflict that causes unnecessary overlapping. A little time to inspect the codebase, quite a few simple moves and here we go, it works properly. Tested a different amount of symbols. Works fine until there's one milliion symbols, but there's no need in such an amount. Tested in Russian langauge and in German (as in the following issue), works as it should.

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: v0.22.0 Beta

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 9, 2024 21:57
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Dec 9, 2024
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc linked an issue Dec 9, 2024 that may be closed by this pull request
6 tasks
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments would be great

@PikachuEXE PikachuEXE changed the title Update ft-shaka-video-player.css Fix Player: Tooltips get cut off with long text Dec 10, 2024
@PikachuEXE
Copy link
Collaborator

Also there is a PR template please follow it

auto-merge was automatically disabled December 10, 2024 01:25

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 10, 2024 01:25
@alexeevrevan
Copy link
Author

Also there is a PR template please follow it

you mean text formatting? OK I'll try to

auto-merge was automatically disabled December 10, 2024 01:34

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 10, 2024 01:34
God please let me pass the linter check
auto-merge was automatically disabled December 10, 2024 01:39

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 10, 2024 01:39
@alexeevrevan
Copy link
Author

Also there is a PR template please follow it

Done editing

@alexeevrevan
Copy link
Author

@absidue
Copy link
Member

absidue commented Dec 10, 2024

@alexeevrevan Please don't unnecessarily ping people, our reviews were already requested and we will get to them when we have time to look at this PR. We are volunteers that work on FreeTube in our spare time, we all have lives outside of it, so yes we don't work on it 24/7. Please be patient, instead of annoying us with extra pings.

@alexeevrevan
Copy link
Author

@alexeevrevan Please don't unnecessarily ping people, our reviews were already requested and we will get to them when we have time to look at this PR. We are volunteers that work on FreeTube in our spare time, we all have lives outside of it, so yes we don't work on it 24/7. Please be patient, instead of annoying us with extra pings.

ok

@kommunarr
Copy link
Collaborator

This particular fix improves the situation for the right-side buttons but worsens it for left-side buttons. An ideal fix would make the title text work like the thumbnail image does currently, which is also how title text works in YT currently.

Screenshot_20241212_140625

@alexeevrevan
Copy link
Author

This particular fix improves the situation for the right-side buttons but worsens it for left-side buttons. An ideal fix would make the title text work like the thumbnail image does currently, which is also how title text works in YT currently.

Screenshot_20241212_140625

thats the good point

@alexeevrevan
Copy link
Author

This particular fix improves the situation for the right-side buttons but worsens it for left-side buttons. An ideal fix would make the title text work like the thumbnail image does currently, which is also how title text works in YT currently.

Screenshot_20241212_140625

when i was about to come to a commit I made I found out that word-break property works just fine avoiding border overlapping by stacking words. but i guess its not youtube-ish enough, hahah.

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Dec 17, 2024
Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

Copy link
Contributor

This PR was closed because it has been stalled for 14 days with no activity.

@github-actions github-actions bot closed this Jan 15, 2025
auto-merge was automatically disabled January 15, 2025 01:56

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Player: Tooltips get cut off with long text
5 participants