-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Player: Tooltips get cut off with long text #6336
Conversation
Tooltip bug fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments would be great
Also there is a PR template please follow it |
…layer.css Co-authored-by: PikachuEXE <[email protected]>
Head branch was pushed to by a user without write access
you mean text formatting? OK I'll try to |
Head branch was pushed to by a user without write access
God please let me pass the linter check
Head branch was pushed to by a user without write access
Done editing |
@alexeevrevan Please don't unnecessarily ping people, our reviews were already requested and we will get to them when we have time to look at this PR. We are volunteers that work on FreeTube in our spare time, we all have lives outside of it, so yes we don't work on it 24/7. Please be patient, instead of annoying us with extra pings. |
ok |
when i was about to come to a commit I made I found out that word-break property works just fine avoiding border overlapping by stacking words. but i guess its not youtube-ish enough, hahah. |
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
This PR was closed because it has been stalled for 14 days with no activity. |
Tooltip bug fixed
Pull Request Type
Related issue
closes #6331
Description
The application was inspected via devtools to find where the bug happens, I fixed it in the code afterwards. Now Tooltip pops up correctly, even with more symbols in it.
Screenshots
Before and After bugfix
Testing
Tried different options right in the browser devtools, found out that there's a css feature conflict that causes unnecessary overlapping. A little time to inspect the codebase, quite a few simple moves and here we go, it works properly. Tested a different amount of symbols. Works fine until there's one milliion symbols, but there's no need in such an amount. Tested in Russian langauge and in German (as in the following issue), works as it should.
Desktop