Change CREATE_NEW_WINDOW IPC call to accept a path and query

[absidue]

Change CREATE_NEW_WINDOW IPC call to accept a path and query

Pull Request Type

• Security improvement

Description

Currently the CREATE_NEW_WINDOW IPC call accepts a URL and performs no validation on it, which means it can be used to open new windows with arbitrary URLs. This pull request locks it down by making it accept a path and query parameters instead, so that it can only be used to create windows with in-app URLs and adds some parameter validation.

Testing

• Please check that the new window button in the top bar still works (calls CREATE_NEW_WINDOW with no parameters)
• Please test opening various queries in new windows from the search bar (SHIFT+ENTER or SHIFT+click on the search button)
  • https://youtu.be/jNQXAC9IVRw (just path)
  • https://youtu.be/jNQXAC9IVRw?t=10 (path and query)
  • test (path, query and searchQueryText) -> the search query text should appear in the search bar in the new window

Desktop

• OS: Windows
• OS Version: 10
• FreeTube version: 7ad5873

[PikachuEXE]

I think to make this easier to read it should be reversed
If query/searchQueryText is not null/undefined and not a value of expected type

Suggested change

	(typeof query !== 'object' && query != null) ||
	(typeof searchQueryText !== 'string' && searchQueryText != null)
	(query != null && typeof query !== 'object') ||
	(searchQueryText != null && typeof searchQueryText !== 'string')