Add watch progress saving setting to have multiple modes #6754
+194
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PikachuEXE
requested review from
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
absidue
reviewed
Feb 19, 2025
Comment on lines
44
to
49
| watchedProgressSavingModeValueNamePairs() { | ||
| return [ | ||
| ['auto', this.$t('Settings.Privacy Settings.Watched Progress Saving Mode.Modes.Auto')], | ||
| ['semi-auto', this.$t('Settings.Privacy Settings.Watched Progress Saving Mode.Modes.Semi-auto')], | ||
| ['never', this.$t('Settings.Privacy Settings.Watched Progress Saving Mode.Modes.Never')], | ||
| ] |
There was a problem hiding this comment.
Can you please split this up into two separate array like we do for the other dropdowns. If you want to group them together we can place the two arrays next to each other when we migrate the privacy settings to the composition API.
github-actions
bot
added
PR: merge conflicts / rebase needed
and removed
PR: waiting for review
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
* development: (58 commits) Convert FtSubscribeButton and watch-video-info SCSS to CSS (FreeTubeApp#6814) Use numbers instead of strings for the DBActions and SyncEvents constants (FreeTubeApp#6815) Translated using Weblate (English (United Kingdom)) Fix: search history text overflows if search term is long (FreeTubeApp#6728) Check if a keyboard composition session is active when pressing 'Enter' on ft-input (FreeTubeApp#6799) use hq img (FreeTubeApp#6826) Move the choose default folder logic to the main process (FreeTubeApp#6811) Translated using Weblate (French) Translated using Weblate (Turkish) Set process.platform at build time (FreeTubeApp#6784) Use logical spec for float (FreeTubeApp#6783) Migrate DataSettings to the composition API (FreeTubeApp#6785) Local API: Improve audio quality by sorting streams, highest bitrate first (FreeTubeApp#6807) Bump sass from 1.84.0 to 1.85.0 (FreeTubeApp#6825) Bump webpack from 5.97.1 to 5.98.0 (FreeTubeApp#6820) Bump postcss from 8.5.1 to 8.5.2 in the stylelint group (FreeTubeApp#6819) Bump the babel group with 2 updates (FreeTubeApp#6817) Bump globals from 15.14.0 to 15.15.0 (FreeTubeApp#6823) Bump sass-loader from 16.0.4 to 16.0.5 (FreeTubeApp#6822) Bump eslint from 9.20.0 to 9.20.1 in the eslint group (FreeTubeApp#6818) ... # Conflicts: # src/renderer/components/watch-video-info/watch-video-info.scss # src/renderer/components/watch-video-info/watch-video-info.vue
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
absidue
added
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
N/A
Description
There are times I want to skip a video in the middle but want to watch later without resuming
And I rarely need to save progress (except a few long videos per week)
This PR makes progress saving setting to have a new mode, now as:
Save Watched Progressenabled before)Save Watched Progressdisabled before)Auto = Save on every video page exit, when video ended and error encountered (e.g. ratelimited and watch session expired). Semi-auto = Like Auto except video page exit, and can save progress manually via a new button.Also updated video page action buttons layout to deal with all buttons visible and window with small width (See screenshots
Screenshots
New button on video page
Settings
Testing
A. "Old" Modes
Automode acts the same as beforeNevermode acts the same as beforeB. New Mode
C. Setting migration
{"_id":"saveWatchedProgress","value":false}Desktop
Additional context