Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add doctrine/coding-standard #123

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

connorhu
Copy link
Collaborator

@connorhu connorhu commented Feb 7, 2024

This is an alternative reality of #112

When I was working on the beberlei/DoctrineExtensions repo I came across the doctrine code standard rules package. This is a much more extensive set of rules than can be done with php-cs-fixer (I can understand why they work with this instead of php-cs-fixer). After the commit in the PR there are still about 4000 bugs that need to be fixed manually. I'm sure I missed all the changes causing breaking changes, but at first glance it looks like this. Since doctrine uses it, I think it might be more appropriate to use it in this repo.

@thePanz thePanz mentioned this pull request Feb 7, 2024
Copy link

@alquerci alquerci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, coding standard is bound to a team not on repository.

All repositories should use the same rules across FriendsOfSymfony1 organization.

@connorhu
Copy link
Collaborator Author

We also have to take into account that the codebase must retain its characteristics. If we had created all the code from the beginning, I would agree with the principle of "the same everywhere" code style, but we are trying to keep code from different places alive (not develop it, because apparently nobody wants that).

@connorhu connorhu force-pushed the feature/phpcs branch 2 times, most recently from 33b3003 to 2a9ce1a Compare February 17, 2024 07:27
@connorhu connorhu marked this pull request as ready for review February 17, 2024 07:30
@connorhu
Copy link
Collaborator Author

errors are gone :)
All in all, I prefer this solution because it has more features than the fixer, it has a better reporting system and therefore it is easier to see on github what the problem is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants