Fix connection binding to component for all autoloaded models #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch for more than one master connection. Modern and symfony1 applications do not use `Doctrine_Core::loadModels()` even conservative or aggressive mode. For such setup models that are bound to a specific connection are attached to the current connection instead of the bound one. After some deeper investigations for the query factory the connection is set on the flow (`_passedConn === false`): * on create set the current connection * call `preQuery()` (usage like on `sfDoctrineMasterSlavePlugin` get the current connection) * on build SQL query (just before execution) it sets the query connection for each components (I do not see any check when at least two components use different connection)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch for more than one master connection.
Modern and symfony1 applications do not use
Doctrine_Core::loadModels()even conservative or aggressive mode.For such setup models that are bound to a specific connection are attached to the current connection instead of the bound one.
After some deeper investigations for the query factory the connection is set on the flow (
_passedConn === false):preQuery()(usage like onsfDoctrineMasterSlavePluginget the current connection)Tests
Add test - https://travis-ci.org/alquerci/doctrine1/builds/429283415
Apply fix - https://travis-ci.org/alquerci/doctrine1/builds/429251947