Added new memcached class (PHP 7.2) #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 24, 2018 10:37
thePanz
reviewed
Oct 29, 2018
| @@ -43,7 +43,7 @@ class Doctrine_Cache_Memcache extends Doctrine_Cache_Driver | |||
| * | |||
| * @param array $options associative array of cache driver options | |||
| */ | |||
| public function __construct($options = array()) | |||
| public function __construct($options = array()) | |||
There was a problem hiding this comment.
Extra space, please remove it :)
regisnew
added a commit
to regisnew/doctrine1
that referenced
this pull request
Oct 2, 2019
Fix extra space reported by @thePanz on your PR. See FriendsOfSymfony1#62
endelwar
reviewed
Oct 2, 2019
| } | ||
|
|
||
| return $this->_memcache->set($id, $data, $flag, $lifeTime); | ||
| return $this->_memcache->set($id, $data, $lifeTime); | ||
| } |
There was a problem hiding this comment.
Why is compression removed? You can use $this->_memcache->setOption(Memcached::OPT_COMPRESSION, true) in __construct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old memcache classes are not even longer maintained.
In PHP 7.2 the package is not longer available.