refactor: swap MMU_EJECT to MMU_UNLOAD #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the upcoming Happy Hare v3, eject behaves slightly different for "Type B" MMU's, where it ejects the spool out of the MMU where unload just retracts and parks it. In Happy Hare v2, `MMU_EJECT` and `MMU_UNLOAD` ran the same code, so they are interchangeable in v2.
Zchulski
approved these changes
Dec 23, 2024
ningpj
approved these changes
Dec 26, 2024
norris108
approved these changes
Dec 27, 2024
ningpj
approved these changes
Dec 29, 2024
|
Is it possible to get this merged soon? I just spent ~20 hours debugging this. |
Frix-x
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the upcoming Happy Hare v3, eject behaves slightly different for "Type B" MMU's, where it ejects the spool out of the MMU where unload just retracts and parks it.
In Happy Hare v2,
MMU_EJECTandMMU_UNLOADran the same code, so they are interchangeable in v2.