-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add blob tx listener #92
Conversation
Co-authored-by: Rodrigo Araújo <[email protected]>
…uel-block-committer into feature/transaction-committer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Crispy :)
Co-authored-by: MujkicA <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left just a small question.
Another question: If I'm not missing anything, this listener simply updates a db table with the status of a tx, but it doesn't perform any action to fix (e.g., retry) failed txs. Is that right?
Yes. The |
Adds a new service
state_listener
which will periodically check if the pending blob tx are finalized.The sql tables for blob support have been updated and look like this:
The sql queries are updated but the functionality remained the same. The new tables make it easier to update the tx state and query for finalized submissions (thans @segfault-magnet for the idea).