Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Fix the events having their values reset when selecting a different event #3913

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[BUGFIX] Fix the events having their values reset when selecting a different event #3913

wants to merge 1 commit into from
+6 −3

Conversation

KoloInDaCrib
Copy link
Contributor

Does this PR close any issues? If so, link them below.

2957

Briefly describe the issue(s) fixed.

Moved some stuff around and utilized pauseEvent and resumeEvent to ensure that values don't get reset when switching to another event.

Include any relevant screenshots or videos.

never-touching-chart-editor-again.mp4

@github-actions github-actions bot added pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. labels Dec 5, 2024
moxie-coder
moxie-coder approved these changes Dec 5, 2024
View reviewed changes
Copy link

@moxie-coder moxie-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet

@Hundrec
Copy link
Collaborator

Hundrec commented Dec 6, 2024

Wait, really?!
That's another massive Kolo W

JVNpixels
JVNpixels approved these changes Dec 8, 2024
View reviewed changes
Copy link
Contributor

@JVNpixels JVNpixels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for saving the chart editor

@EliteMasterEric EliteMasterEric added the status: pending triage Awaiting review. label Jan 17, 2025
@Hundrec Hundrec added type: minor bug Involves a minor bug or issue. topic: chart editor Related to the operation of the Chart Editor. labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JVNpixels JVNpixels JVNpixels approved these changes

@moxie-coder moxie-coder moxie-coder approved these changes

@charlesisfeline charlesisfeline charlesisfeline approved these changes

@cyn0x8 cyn0x8 cyn0x8 approved these changes

Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. status: pending triage Awaiting review. topic: chart editor Related to the operation of the Chart Editor. type: minor bug Involves a minor bug or issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@KoloInDaCrib @Hundrec @cyn0x8 @charlesisfeline @moxie-coder @JVNpixels @EliteMasterEric