[ENHANCEMENT] [MODDING] Custom render distance for Strumline.hx #3959
+13
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
haxe
charlesisfeline
approved these changes
Dec 28, 2024
|
Going to merge this into one pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
N/A
Briefly describe the issue(s) fixed.
Adds
CUSTOM_RENDER_DISTANCE_MS, andUSE_CUSTOM_RENDER_DISTANCEas public static variables in Strumline.hx.These control the
get_RENDER_DISTANCE_MS()private static getter and return a custom render distance ifUSE_CUSTOM_RENDER_DISTANCEis true.These new public static variables are documented and shouldn't affect anything in vanilla base game at all.
The only problem I could see is a module forgetting to reset
USE_CUSTOM_RENDER_DISTANCE.