Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable note hit sounds & effects #4112

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

FlooferLand
Copy link
Contributor

@FlooferLand FlooferLand commented Feb 6, 2025

This PR adds note hit sound effects, as well as a little sound system for playing general note-related sounds.
It also adds a settings toggle for note splash particles, as requested by a // TODO I saw.

See FunkinCrew/funkin.assets/preload/sounds/noteSounds/how to.txt to see how to add new sounds

Video showcase

https://www.youtube.com/watch?v=K-nh51LEa7U
(or a catbox.moe mirror)


Associated assets PR: FunkinCrew/funkin.assets#36

This PR was previously #2793.
Made a new PR as I rewrote everything and the old PR contained remnants of the new settings widget system

@github-actions github-actions bot added status: pending triage Awaiting review. pr: haxe PR modifies game code. size: large A large pull request with more than 100 changes. labels Feb 6, 2025
@Hundrec Hundrec added status: needs revision Cannot be approved because it is awaiting some work by the contributor. type: enhancement Involves an enhancement or new feature. and removed status: pending triage Awaiting review. labels Feb 6, 2025
@Hundrec
Copy link
Collaborator

Hundrec commented Feb 6, 2025

Please change the base branch to develop at the top of this PR!

@amyspark-ng
Copy link
Contributor

🔥🔥🔥🔥🔥

@FlooferLand FlooferLand changed the base branch from main to develop February 7, 2025 06:26
@FlooferLand
Copy link
Contributor Author

FlooferLand commented Feb 7, 2025

I always forget about the develop branch, my bad.

Not sure how to change my fork / local repo over to the develop branch without risking accidentally nuking the entire PR again, I think I give the lead maintainers a heart attack any time they see me do anything with git lmao

Also, I solved a conflict and someone added a showNotesplash to Strumline.hx, but it doesn't seem to be used by anything?

@Hundrec Hundrec added status: pending triage Awaiting review. and removed status: needs revision Cannot be approved because it is awaiting some work by the contributor. labels Feb 7, 2025
@Lasercar
Copy link
Contributor

Lasercar commented Feb 8, 2025

I always forget about the develop branch, my bad.

Not sure how to change my fork / local repo over to the develop branch without risking accidentally nuking the entire PR again, I think I give the lead maintainers a heart attack any time they see me do anything with git lmao

Just start the branch using the develop one as a base, rather than main. Then, when you make the PR, make sure you're requesting to merge into the develop branch and you should be fine!

Also, if you click the dropdown of the conflict fix thing below when there's a conflict, you can choose to rebase it rather than merge to keep the commits clean.

If you plan to continue working on the PR/branch after that, make sure that you pull the rebased branch from your remote origin of the branch first.

@AbnormalPoof
Copy link
Collaborator

AbnormalPoof commented Feb 8, 2025

I always forget about the develop branch, my bad.

Not sure how to change my fork / local repo over to the develop branch without risking accidentally nuking the entire PR again, I think I give the lead maintainers a heart attack any time they see me do anything with git lmao

Also, I solved a conflict and someone added a showNotesplash to Strumline.hx, but it doesn't seem to be used by anything?

showNotesplash is for mods. It's so that mods can disable/enable note splashes at will. (See #4009)

@AbnormalPoof
Copy link
Collaborator

This PR appears to have merge conflicts. Please fix them!

@AbnormalPoof AbnormalPoof added status: needs revision Cannot be approved because it is awaiting some work by the contributor. and removed status: pending triage Awaiting review. labels Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: haxe PR modifies game code. size: large A large pull request with more than 100 changes. status: needs revision Cannot be approved because it is awaiting some work by the contributor. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants