-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customizable note hit sounds & effects #4112
base: develop
Are you sure you want to change the base?
Conversation
Please change the base branch to develop at the top of this PR! |
🔥🔥🔥🔥🔥 |
I always forget about the Not sure how to change my fork / local repo over to the Also, I solved a conflict and someone added a |
Just start the branch using the develop one as a base, rather than main. Then, when you make the PR, make sure you're requesting to merge into the develop branch and you should be fine! Also, if you click the dropdown of the conflict fix thing below when there's a conflict, you can choose to rebase it rather than merge to keep the commits clean. If you plan to continue working on the PR/branch after that, make sure that you pull the rebased branch from your remote origin of the branch first. |
|
This PR appears to have merge conflicts. Please fix them! |
This PR adds note hit sound effects, as well as a little sound system for playing general note-related sounds.
It also adds a settings toggle for note splash particles, as requested by a
// TODO
I saw.See FunkinCrew/funkin.assets/preload/sounds/noteSounds/how to.txt to see how to add new sounds
Video showcase
https://www.youtube.com/watch?v=K-nh51LEa7U
(or a catbox.moe mirror)
Associated assets PR: FunkinCrew/funkin.assets#36
This PR was previously #2793.
Made a new PR as I rewrote everything and the old PR contained remnants of the new settings widget system