Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Report: Pico's burpShit animation doesn't restore player's vocal volume #3545

Open
2 tasks done
Hundrec opened this issue Oct 3, 2024 · 2 comments · May be fixed by FunkinCrew/funkin.assets#71
Open
2 tasks done

Bug Report: Pico's burpShit animation doesn't restore player's vocal volume #3545

Hundrec opened this issue Oct 3, 2024 · 2 comments · May be fixed by FunkinCrew/funkin.assets#71
Labels
status: pending pull request Dependent on a pull request that is currently awaiting review. type: minor bug Involves a minor bug or issue.

Comments

@Hundrec
Copy link
Collaborator

Hundrec commented Oct 3, 2024 •
edited
Loading

Issue Checklist

  • I have properly named my issue
  • I have checked the Issues/Discussions pages to see if my issue has already been reported

Platform

Itch.io (Downloadable Build) - Windows

Browser

None

Version

0.5.1

Description (include any images, videos, errors, or crash logs)

Update 0.5.1 introduced a partial fix to Pico's burps being muted by missing notes. However, burpShit can still be muted.

I've started a pull request in funkin.assets to add the missing animation here: FunkinCrew/funkin.assets#71

burpShit.volume.bug.mp4

Steps to Reproduce

  1. Play South (Pico Mix)
  2. Miss a note or ghost tap before Pico burps at the end of the song
@Hundrec Hundrec added status: pending triage Awaiting review. type: minor bug Involves a minor bug or issue. labels Oct 3, 2024
@Hundrec Hundrec linked a pull request Oct 3, 2024 that will close this issue
Open
@sphis-Sinco
Copy link

thats because theres no note being pressed

@Hundrec
Copy link
Collaborator Author

Hundrec commented Nov 10, 2024

Please view the linked PR.

@Hundrec Hundrec added status: pending pull request Dependent on a pull request that is currently awaiting review. and removed status: pending triage Awaiting review. labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: pending pull request Dependent on a pull request that is currently awaiting review. type: minor bug Involves a minor bug or issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure volume enables for burpShit animation as well Hundrec/funkin.assets
2 participants
@sphis-Sinco @Hundrec