Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure volume enables for burpShit animation as well #71

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Hundrec
Copy link
Collaborator

@Hundrec Hundrec commented Oct 3, 2024

Linked Issues

Fixes FunkinCrew/Funkin#3545

Description

This commit made it so that burpSmile and burpSmileLong would set playerVolume to 1 so that Pico's burps would always be heard.

This PR adds burpShit to the list of animations, ensuring that Pico can burp to his heart's content.

South (Pico Mix) in 0.5.1

burpShit.volume.bug.mp4

Now Pico can burp to his heart's content!
@NotHyper-474
Copy link

NotHyper-474 commented Oct 3, 2024

I don't know if HScript supports it but all those checks could probably be simplified into a if (name.startsWith("burp"))
Edit: It does support it but not as an extension for String, so StringTools.startsWith would need to be used instead.

But good PR 👍

@EliteMasterEric EliteMasterEric added the status: pending triage The bug or PR has not been reviewed yet. label Oct 15, 2024
@AbnormalPoof AbnormalPoof added type: minor bug Involves a minor bug or issue. size: small A small pull request with 10 or fewer changes labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: small A small pull request with 10 or fewer changes status: pending triage The bug or PR has not been reviewed yet. type: minor bug Involves a minor bug or issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: Pico's burpShit animation doesn't restore player's vocal volume
4 participants