Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Some spirtes have "invisible pixels" #12

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Fix: Some spirtes have "invisible pixels" #12

wants to merge 23 commits into from

Conversation

D4rkJony
Copy link

daddypixel.png, gfPixel.png and icon-tankman.png all have invisible pixels, so I fixed them, but since there was no "images" file in the Funkin.assets repository (for the freeplay and gameplay icons) I put the fixed sprites on the main branch, please implement them

AppleHair
AppleHair suggested changes May 27, 2024
View reviewed changes
Copy link

@AppleHair AppleHair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should put "daddypixel.png" in "preload/images/freeplay/icons",
put "gfPixel.png" in "shared/images/characters", while keeping the ".png" file extention,
and put "icon-tankman.png" in "preload/images/icons".
Thank you and have a great day 👍

@D4rkJony
Copy link
Author

YOOOOOOOOOOOOOOO, thanks a lot bro, really apreciated it

AppleHair
AppleHair suggested changes May 27, 2024
View reviewed changes
Copy link

@AppleHair AppleHair left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just ensure you have the ".png" file extension on all the files you've changed.
Apart from that, I don't see any major problems 👍

preload/images/freeplay/icons/daddyPixel Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the ".png" file extension back

exclude/oldgfPixel Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the ".png" file extension back

@D4rkJony
Copy link
Author

Oh yeah, I forgot bout putting the .png extension in some of those, I'll fix it, thanks again for warning me since this is my first time working on github

@NotHyper-474 NotHyper-474 mentioned this pull request Jun 11, 2024
Closed
@EliteMasterEric EliteMasterEric added the status: pending triage The bug or PR has not been reviewed yet. label Jul 9, 2024
@EliteMasterEric EliteMasterEric added status: needs revision Cannot be approved because it is awaiting some work by the contributor. size: small A small pull request with 10 or fewer changes and removed status: pending triage The bug or PR has not been reviewed yet. labels Oct 15, 2024
@AbnormalPoof
Copy link
Collaborator

This PR appears to have merge conflicts. Please fix them!

@AbnormalPoof AbnormalPoof added the type: minor bug Involves a minor bug or issue. label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AppleHair AppleHair AppleHair approved these changes

Assignees
No one assigned
Labels
size: small A small pull request with 10 or fewer changes status: needs revision Cannot be approved because it is awaiting some work by the contributor. type: minor bug Involves a minor bug or issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@D4rkJony @AbnormalPoof @AppleHair @EliteMasterEric