Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCEMENT] More Note Splash data customization #41

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[ENHANCEMENT] More Note Splash data customization #41

wants to merge 1 commit into from

Conversation

CrusherNotDrip
Copy link

@CrusherNotDrip CrusherNotDrip commented Jun 28, 2024 •
edited
Loading

THIS PULL REQUEST ALSO REQUIRES FunkinCrew/Funkin#2929 TO BE PUSHED!

What is this PR?

This pull request adds onto the note splash data and adds more customization to them!

This adds/now supports:

  • assetPath (String)
  • scale (Float)
  • offsets (Array (Float))
  • isPixel (Bool)
  • data/splash1Left (String)
  • data/splash2Left (String)
  • data/splash1Down (String)
  • data/splash2Down (String)
  • data/splash1Up (String)
  • data/splash2Up (String)
  • data/splash1Right (String)
  • data/splash2Right (String)

Known Issues:

  • Honestly the only one I know of is that if any data/splashVarientDir doesn't exist, it won't call the fallback one. If a note splash is disabled though it won't be a problem.

@CrusherNotDrip CrusherNotDrip mentioned this pull request Jun 28, 2024
Open
@EliteMasterEric EliteMasterEric added status: reviewing internally Cannot be approved; under continuing review and quality assurance testing status: pending triage The bug or PR has not been reviewed yet. and removed status: reviewing internally Cannot be approved; under continuing review and quality assurance testing labels Jul 9, 2024
@AbnormalPoof AbnormalPoof added type: enhancement Provides an enhancement or new feature. size: medium A medium pull request with 100 or fewer changes status: pending pull request Has a PR which resolves it that is pending review. and removed status: pending triage The bug or PR has not been reviewed yet. labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size: medium A medium pull request with 100 or fewer changes status: pending pull request Has a PR which resolves it that is pending review. type: enhancement Provides an enhancement or new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CrusherNotDrip @EliteMasterEric @AbnormalPoof