GH-81 Check permissions in tab-completion (Resolve #81)

FunnyGuilds · Sep 8, 2024 · f4e8411 · f4e8411
1 parent ef62b67
commit f4e8411
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -24,7 +24,7 @@ Add these declarations to your `pom.xml`.
   <dependency>
     <groupId>net.dzikoysk</groupId>
     <artifactId>funnycommands</artifactId>
-    <version>0.7.0</version>
+    <version>0.7.1</version>
   </dependency>
 </dependencies>
 ```
@@ -37,7 +37,7 @@ repositories {
 }
 
 dependencies {
-  implementation "net.dzikoysk:funnycommands:0.7.0"
+  implementation "net.dzikoysk:funnycommands:0.7.1"
 }
 ```
 

diff --git a/build.gradle.kts b/build.gradle.kts
@@ -16,7 +16,7 @@ allprojects {
     apply(plugin = "maven-publish")
 
     group = "net.dzikoysk"
-    version = "0.7.0"
+    version = "0.7.1"
 
     repositories {
         mavenCentral()

diff --git a/funnycommands/src/main/java/net/dzikoysk/funnycommands/commands/DynamicCommand.java b/funnycommands/src/main/java/net/dzikoysk/funnycommands/commands/DynamicCommand.java
@@ -170,6 +170,11 @@ public List<String> tabComplete(CommandSender sender, String alias, String[] arg
 
         CommandInfo commandInfo = context.getCommandStructure().getMetadata().getCommandInfo();
 
+        // skip completion for unauthorized commands
+        if (!commandInfo.getPermission().isEmpty() && !sender.hasPermission(commandInfo.getPermission())) {
+            return Collections.emptyList();
+        }
+
         // skip undefined completions
         if (commandInfo.getCompletes().isEmpty()) {
             return Collections.emptyList();

diff --git a/funnycommands/src/main/resources/plugin.yml b/funnycommands/src/main/resources/plugin.yml
@@ -1,4 +1,4 @@
 name: FunnyCommands
 main: net.dzikoysk.funnycommands.FunnyCommandsPlugin
-version: 0.7.0
+version: 0.7.1
 author: dzikoysk