Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Feat ] Group Ranking 퍼블리싱 #104

Merged
merged 19 commits into from
Oct 20, 2024
Merged

[ Feat ] Group Ranking 퍼블리싱 #104

merged 19 commits into from
Oct 20, 2024

Conversation

j-nary
Copy link
Member

@j-nary j-nary commented Oct 13, 2024

#️⃣ Related Issue

Closes #98

✅ Done Task

  • Ranking tab 수정 및 추가
  • Top Ranking 구현
  • All Ranking 구현
  • 페이지네이션 추가

☀️ New-insight

  • 단순 퍼블리싱이라 새롭게 알게 된 부분 없었습니다!

💎 PR Point

Tab 수정 사항 관련

  • Tab secondary 관련해서만 css 속성 변경 했습니다
  • 원래 primary로 되어있던 게 지금 Navbar로 이전됐지 않나요? primary가 왜 있는지 궁금합니다!

Commit 기록 관련

📸 Screenshot

2024-10-13.9.28.58.mov

@j-nary j-nary added ✨ Feat 새로운 기능 구현 JIN 이진 labels Oct 13, 2024
@j-nary j-nary self-assigned this Oct 13, 2024
@GAMZA-BAT GAMZA-BAT deleted a comment from github-actions bot Oct 13, 2024
@GAMZA-BAT GAMZA-BAT deleted a comment from github-actions bot Oct 13, 2024
Copy link

PR이 1000줄을 넘었는데 진정 이것이 PR인지 다시 생각해보세오 이슈를 여러개 파서 PR을 분리하는게 어떠싱지 ㅋ

@github-actions github-actions bot added size/l and removed size/xl labels Oct 16, 2024
Copy link
Member

@wuzoo wuzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@j-nary j-nary merged commit 4d98b7b into main Oct 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feat 새로운 기능 구현 JIN 이진 size/l
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GroupPage - TOP/전체 랭킹 퍼블리싱
3 participants