Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Feat ] instagram, mail 링크 추가 #113

Merged
merged 2 commits into from
Oct 15, 2024
Merged

[ Feat ] instagram, mail 링크 추가 #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60ed6db
feat: instagram, mail 링크 추가
j-nary Oct 15, 2024
7b0dcff
fix: CI 빌드에러 해결
j-nary Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/shared/component/GroupInfoForm/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ const GroupInfoForm = ({
form,
variant = "create-group",
}: GroupFormProps) => {
const handleSubmit = (values: z.infer<typeof groupSchema>) => {
console.log({ values });
const handleSubmit = (_values: z.infer<typeof groupSchema>) => {
// console.log({ values });
};

return (
Expand Down
43 changes: 20 additions & 23 deletions src/view/onboarding/Footer/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
"use client";
import { IcnInstagram, IcnLogo, IcnMail } from "@/asset/svg";
import Link from "next/link";
import {
buttonContainer,
footerStyle,
Expand All @@ -10,33 +10,30 @@ import {
} from "./index.css";

const Footer = () => {
const handleInstaClick = () => {
window.open("http://www.instagram.com", "_blank");
};
const handleMailClick = () => {
alert("mail");
};
return (
<footer className={footerStyle}>
<div className={buttonContainer}>
<IcnLogo className={logoStyle} aria-label="algoHub 로고" />
<div className={iconContainer}>
<IcnInstagram
className={iconStyle}
role="button"
onClick={handleInstaClick}
// onKeyDown
tabIndex={0}
aria-label="instagram을 새 창에서 열기"
/>
<IcnMail
className={iconStyle}
role="button"
onClick={handleMailClick}
// onKeyDown
tabIndex={0}
aria-label="메일 보내기"
/>
<Link
href="https://www.instagram.com/algohub.official/"
target="_blank"
>
<IcnInstagram
className={iconStyle}
role="button"
tabIndex={0}
aria-label="instagram을 새 창에서 열기"
/>
</Link>
<Link href="mailto:[email protected]" target="_blank">
<IcnMail
className={iconStyle}
role="button"
tabIndex={0}
aria-label="메일 보내기"
/>
</Link>
</div>
</div>
<p className={textStyle}>Copyright 2024. Algohub All rights reserved.</p>
Expand Down