[ Feat ] Item 컴포넌트에 수정 기능 Edit 아이콘 추가 #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-nary
approved these changes
Oct 16, 2024
| const Icon = getTierImage(tier); | ||
|
|
||
| const accuracy = ((solved / total) * 100).toFixed(0); | ||
|
|
||
| return ( | ||
| <li aria-label={`문제: ${title}`} className={itemStyle}> | ||
| <li | ||
| // biome-ignore lint/a11y/useKeyWithMouseEvents: |
There was a problem hiding this comment.
useA11yHoverHandler 추가해주시면 될 것 같습니다!
There was a problem hiding this comment.
shared/hook/useAllyHandler.ts에 있는 함수인데, 사용 방법은 JSDoc 보시면 쉽게 이해되실 겁니다.
지금에 와서 해당 훅을 보니 rest 파라미터를 통해 태그 속성에 {...handlers} 처럼 쓰게 하면 사용하기 더 편하겠다는 생각이 드네요.
2 tasks
j-nary
reviewed
Oct 21, 2024
ptyoiy
approved these changes
Oct 22, 2024
|
LGTM! 고생 많으셨슴다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ Related Issue
Closes #120
✅ Done Task
💎 PR Point
단순 퍼블리싱이였습니다 !
📸 Screenshot
2024-10-16.2.50.48.mov