Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Feat ] my page - alarm setting 탭 구현 #132

Merged
merged 17 commits into from
Oct 21, 2024

Conversation

ptyoiy
Copy link
Contributor

@ptyoiy ptyoiy commented Oct 18, 2024

#️⃣ Related Issue

Closes #126

✅ Done Task

  • 알람 설정 탭 구현
  • 다른 탭 코드와 잘 병합 및 구조 정리

☀️ New-insight

테이블 pr #78 에서 다룬 내용 뿐이라 없습니다.

💎 PR Point

  • 테이블 메타데이터 설명 (view/user/setting/AlarmSetting/AlarmSettingTable/constant.tsx)
    • 알림 설정 Cell
      selected state를 두어 토글 버튼을 조작할 수 있게 했습니다. 로컬 스토리지나 api 적용에 따라 코드가 약간 변경될 것 같네요.
    • 그 외 Cell
      값이 바뀌면 업데이트된 배열이 들어와 업데이트 된 값을 사용할 수 있기 때문에 내부에서 p태그를 사용하여 글자 색을 변경합니다. alarm 토글 값이 true면 흰색, 아니면 회색입니다.
    ({ alarm, problemRegistration }) => (
      <p className={clsx(textStyle({ isSelected: alarm }))}>
        {problemRegistration ? "ON" : "OFF"}
      </p>
    )

📸 Screenshot

image

@ptyoiy ptyoiy added ✨ Feat 새로운 기능 구현 GYU 곽규한 labels Oct 18, 2024
Copy link
Member

@j-nary j-nary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 수고하셨습니다!

Comment on lines 7 to 9
import { editCardStyle, footerStyle } from "../index.css";
import { contentStyle, formStyle, labelStyle } from "./index.css";
import useEditForm from "./useEditForm";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

절대경로로 통일해주실 수 있나용?

Copy link
Member

@wuzoo wuzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨씁니다 ~~ 🚀

Copy link
Member

@wuzoo wuzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

깔끔하네요 ! 고생하셨습니답

@ptyoiy ptyoiy merged commit a3425e1 into main Oct 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feat 새로운 기능 구현 GYU 곽규한 size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MyPage - 알람 관리 구현
3 participants