[ Feat ] 알림 목록 조회 API 연결 및 알람 드롭다운 UI 일부 수정 #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-nary
approved these changes
Nov 19, 2024
| import type { HTMLAttributes } from "react"; | ||
| import AlarmListItem from "./AlarmListItem"; | ||
|
|
||
| type AlarmProps = HTMLAttributes<HTMLUListElement>; | ||
| interface AlarmProps extends HTMLAttributes<HTMLUListElement> { | ||
| alarmList: NotificationItem[]; |
There was a problem hiding this comment.
notificationList 로 네이밍 맞추는 게 어떨까요 ? 파일명도 Notification 으로 통일해주시면 감사합니다!
Comment on lines
+24
to
+27
| await queryClient.prefetchQuery({ | ||
| queryKey: ["notifications"], | ||
| queryFn: getNotificationList, | ||
| }); |
There was a problem hiding this comment.
prefetchQuery 사용하는 것 배워갑니다! 좋은 코드 감사합니다 :)
j-nary
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ Related Issue
Closes #207
✅ Done Task
💎 PR Point
getNotificationListapi 작성해주었고, 이에 따른 query 또한 생성해주었습니다.쿼리를 사용할 때
Header는 서버 컴포넌트로 활용 가능하기 때문에, 상위에서prefetch해주고,UserMenu에서는 해당 캐시를 쿼리로부터 빠르게 가져올 수 있도록hydration적용해주었습니다.또한 알람 드롭다운 스타일을 일부 수정하였는데, 패딩값 조정하고
overscrollBehavior적용해주어 포인터가 드롭다운 위에 있을 때는 끝까지 내려도 뒤 백그라운드가 스크롤되지 않도록 설정하였습니다.알림 읽음 api는 수정이 필요할 것 같아서, 서버에서 완료되면 그 때 다시 반영하겠습니다.
📸 Screenshot
2024-11-19.12.28.39.mov