Updates to allow building MAPL with Spack instead of Baselibs #2229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
mathomp4
added
the
0 Diff
mathomp4
changed the title
mathomp4
changed the title
tclune
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR has changes needed to build MAPL with Spack as the libraries instead of Baselibs. Note that this is different than building MAPL with Spack (i.e.,
spack install mapl) but rather using spack as the provider of everything needed for Spack.The main change is that we need to now include
FindESMF.cmakeinside of MAPL. The reason is that the spack ESMF package doesn't not readily expose where that file is in the installation of ESMF. It's not impossible to find, but Spack doesn't really lend itself to exposing its internals easily. I could work with @climbfuji and probably figure something out, but for now, just adding the file here is "easy". My guess is this won't interfere with building MAPL with Spack as theFindESMF.cmakefile would be identical, but this will be needed to be tested.We also move to turn
BUILD_WITH_FLAPto defaultOFFas that won't be in Spack. This is fine for GEOSgcm and GEOSldas but GEOSadas still needs FLAP. So in our CI, we explicitly turn it on. As our CI currently uses Baselibs, we can do this as FLAP is there. Eventually I'll need to add CI that uses spack instead of Baselibs.Related Issue
Motivation and Context
This is a step to allowing us to build MAPL (and eventually GEOS) with using spack as our libraries and not Baselibs.
How Has This Been Tested?
I've build MAPL. Need to do more testing.
Types of changes
Checklist: