Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: repair workflows integrationtests docker #1893

Draft
wants to merge 14 commits into
base: feat/graph-repo-client
Choose a base branch
from

Conversation

MichaelsJP
Copy link
Member

Pull Request Checklist

  • 1. I have rebased the latest version of the main branch into my feature branch and all conflicts
    have been resolved.
  • 2. I have added information about the change/addition to functionality to the CHANGELOG.md file under the
    [Unreleased] heading.
  • 3. I have documented my code using JDocs tags.
  • 4. I have removed unnecessary commented out code, imports and System.out.println statements.
  • 5. I have written JUnit tests for any new methods/classes and ensured that they pass.
  • 6. I have created API tests for any new functionality exposed to the API.
  • 7. If changes/additions are made to the ors-config.json file, I have added these to the ors config documentation
    along with a short description of what it is for, and documented this in the Pull Request (below).
  • 8. I have built graphs with my code of the Heidelberg.osm.gz file and run the api-tests with all test passing
  • 9. I have referenced the Issue Number in the Pull Request (if the changes were from an issue).
  • 10. For new features or changes involving building of graphs, I have tested on a larger dataset
    (at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
  • 11. For new features or changes involving the graphbuilding process (i.e. changing encoders, updating the
    importer etc.), I have generated longer distance routes for the affected profiles with different options
    (avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
    points generated from the current live ORS.
    If there are differences then the reasoning for these MUST be documented in the pull request.
  • 12. I have written in the Pull Request information about the changes made including their intended usage
    and why the change was needed.
  • 13. For changes touching the API documentation, I have tested that the API playground renders correctly.

Fixes # .

Information about the changes

  • Key functionality added:
  • Reason for change:

Examples and reasons for differences between live ORS routes, and those generated from this pull request

Required changes to ors config (if applicable)

@github-actions github-actions bot added the fix label Nov 11, 2024
@MichaelsJP MichaelsJP changed the base branch from main to feat/graph-repo-client November 11, 2024 19:19
@github-actions github-actions bot added fix and removed fix labels Nov 11, 2024
@MichaelsJP MichaelsJP marked this pull request as ready for review November 11, 2024 19:20
@github-actions github-actions bot added fix and removed fix labels Nov 11, 2024
@MichaelsJP MichaelsJP closed this Nov 11, 2024
@MichaelsJP MichaelsJP reopened this Nov 11, 2024
@github-actions github-actions bot added fix and removed fix labels Nov 11, 2024
@MichaelsJP MichaelsJP force-pushed the fix/repair-workflows-integrationtests-docker branch 19 times, most recently from bdae234 to 2e0c4cf Compare November 12, 2024 12:34
@MichaelsJP MichaelsJP force-pushed the fix/repair-workflows-integrationtests-docker branch 7 times, most recently from 01bf2ea to 746bbe7 Compare November 17, 2024 20:03
@MichaelsJP MichaelsJP force-pushed the fix/repair-workflows-integrationtests-docker branch 3 times, most recently from f205086 to af54af0 Compare November 17, 2024 23:01
@MichaelsJP MichaelsJP force-pushed the fix/repair-workflows-integrationtests-docker branch 4 times, most recently from 5b73100 to 6b3325a Compare November 17, 2024 23:28
Currently, the matrix workflow is still downloading the dependencies.
@MichaelsJP MichaelsJP force-pushed the fix/repair-workflows-integrationtests-docker branch from 6b3325a to 7687a89 Compare November 17, 2024 23:33
@MichaelsJP MichaelsJP force-pushed the fix/repair-workflows-integrationtests-docker branch from 7b6ce52 to 836bcdb Compare November 18, 2024 14:22
This helps to keep the docker caches separate and cache it more efficiently, e.g. in CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant