-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker updates #129
Docker updates #129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Using the makefile to build the image
✅ Running the image
✅ Using flyway inside the container on start
So next I tried to use the image to test a PR :-)
Based on the dockerfile I saw Chado was cloned at the root so I cd'd in and switched the branch to an existing PR. Then I tried using flyway info
and ran found out it couldn't be used anywhere but the root directory.
Notes:
- We could use some docs related to how to use the docker to test a PR and inspect the schema.
- flyway only works if you're in the root directory. This is a pain if you need to change branches first.
- docs on using psql to actually check the schema would also be nice :-D especially if there were an alias so you can just use
psql
without args for those who don't read the docs ;-)
Okay, I've made the changes you requested @laceysanderson . You can now run Flyway from anywhere in the image (no need to be in the root folder) and the README has been updated to tell you how to find where the Chado repository is installed and how to run I also make one additional change. I changed the version of this Docker image to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very useful--thanks @spficklin !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks! This looks good to me and works as expected now :-) 👍
Two reviews approving this change so this is ready to merge @scottcain 🎉 Thanks @spficklin this is going to make reviewing migration PRS so much easier! |
Issue: #128
This PR updates the docker image provided by this repository to:
Dockerfile
andflyway.conf
files. This is necessary because flyway cannot connect via the UNIX socket.motd
that warns the user not to use this for production (See below)entryfile
script that runs the postgresql server and drops the user to a bash shell.To Test
Build the docker image using the new makefile
cd docker make v1.31
Startup the image:
To test Flyway changes, change Chado to use the 1.4 branch
cd /Chado/ git checkout 1.4
Run Flyway from the root directory:
Examples
The warning message when the image first starts:
Example usage of the
flyway info
command: