Fix buffer overflow in lnx_eth_get_dev_index.

If the name was longer than IFNAMSIZ then it would corrupt data.
GNS3 · Mar 24, 2024 · 7356141 · 7356141
1 parent 2bac780
commit 7356141
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/common/linux_eth.c b/common/linux_eth.c
@@ -46,7 +46,8 @@ int lnx_eth_get_dev_index(char *name)
    }
 
    memset((void *)&if_req,0,sizeof(if_req));
-   strcpy(if_req.ifr_name,name);
+   strncpy(if_req.ifr_name,name,IFNAMSIZ-1);
+   if_req.ifr_name[IFNAMSIZ-1] = '\0';
 
    if (ioctl(fd,SIOCGIFINDEX,&if_req) < 0) {
       fprintf(stderr,"eth_get_dev_index: SIOCGIFINDEX: %s\n",strerror(errno));