Warn when SO_REUSEADDR is not set. #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a "minimum effort" warning. When a socket bind/listen fails without SO_REUSEADDR then the ip-port combination might be in the TIME_WAIT state. There is no way to test if that is actual case, so just warn the user.
|
I'm not a network person, I'm here mostly for the virtual hardware. |
|
@grossmj: for now I'm only doing PRs handling what coverity detects (like this one) and only 1 at a time. |
|
Ok got it. Yes I would like to have this one on hold. I haven't had time to check why the situation you described could happen. |
grossmj
reviewed
Apr 2, 2024
flaviojs
force-pushed
the
warn-SO_REUSEADDR-not-set
branch
from
59b2177 to
cf73f37
Compare
|
SO_REUSEADDR is also being set in UDP sockets, no idea what the effect is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a "minimum effort" warning.
When a socket bind/listen fails without SO_REUSEADDR then the ip-port combination might be in the TIME_WAIT state.
There is no way to test if that is actual case, so just warn the user.