-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new GCN alerts and SCIMMA broker #84
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jul 23, 2024
This seems to be working live, with the NASA brokers going through the hop client. Once SCIMMA adds the new GCNs then we can look at swapping over. There are some annoying errors that appear in the logs but they seem to be harmless, I'll look at making another issue for them. |
This was referenced Jul 30, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
-event_handler
Issues/PRs related to the event handler
-events_GRB
Issues/PRs related to GRB events
-sentinel
Issues/PRs related to the sentinel alert listener
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some major upgrades for the sentinel alert listener and backend code:
hop-client
backend (Move from GCN Kafka client to SCIMMA's Hop Client #81). Ironically, after implementing that it tuns out that the SCIMMA broker currently doesn't process the EP alerts which meant having to switch back to the NASA GCN broker (but still using hop). Aside from a few alerts on the first connection it seems to be working well, but it will need longer-term testing.SkyMap
class. Also we failed to save skymaps with COMMENT headers correctly, so that needed a fix.Things to do before this can be merged: