GPII-779: Add support in Android for detecting installed solutions #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adding the initial stub - Adding required bits to create the stub into makestubs.sh
- Create a useful JSON output - Disable some parts of the device reporting - Code clean up
This file is no longer required because it was just an example of how the device reporter should be called from a js script.
|
@javihernandez Is this still ready to be reviewed and merged? Or do you need to any work on it post-fireball before I take a look at it? |
Conflicts: gpii.js
|
updated with current master |
|
I've added some tests, linted, etc, so this is ready again for another round of review. BUT, since we can't set environmental variables in the same way we do in windows and linux, we can't tell the gpii to start with a different configuration than the default one. So, we have two options:
If you're with me, let me know and I can apply this last change to the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes:
It should be tested within GPII/universal#246 and GPII/universal#259, and by using the configuration "fm.ps.sr.dr.mm.os.lms.production".