Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RPSL explorer compilation not working on Windows #29

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Mcgode
Copy link

@Mcgode Mcgode commented May 6, 2023

The RPSL compilation command does not work on Windows, and seems to have been designed for Unix-like systems.

This PR fixes the command line for Windows, while keeping compatibility with Unix systems.
Addresses #28

@expenses
Copy link

expenses commented May 8, 2023

I think using the std::filesystem:path functions would be tidier: https://en.cppreference.com/w/cpp/filesystem/path/make_preferred. But I'm not sure what version of c++ RPS is targetting.

@Mcgode
Copy link
Author

Mcgode commented May 9, 2023

Indeed, thanks for the comment.

The RPS lib itself target C++11 but rpsl_explorer.hpp itself uses C++17 (and already uses std::filesystem::path in the same function)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants