Skip to content

Commit

Permalink
SRCH-2219 - Remove Ruby 2.5 from ASIS CircleCI (#89)
Browse files Browse the repository at this point in the history
* SRCH-2219 - Remove Ruby 2.5 from ASIS CircleCI

Removed all traces Ruby 2.5. Also switched parameters to matrix
syntax, and removed defaults for all parameters, since the matrix
should handle all values, and we actually _want_ it to blow up if
that's not happening.

* SRCH-2219 - Code review comments

Changed matrix syntax and added Ruby 2.7.3
  • Loading branch information
jmax-fearless authored May 14, 2021
1 parent 221fb9a commit 816fec4
Showing 1 changed file with 8 additions and 9 deletions.
17 changes: 8 additions & 9 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ jobs:
type: string
elasticsearch_version:
type: string
default: 6.8.15
steps:
- checkout
- run:
Expand Down Expand Up @@ -69,17 +68,17 @@ jobs:
workflows:
build_and_test:
jobs:
- build:
name: 'ruby 2.5, ES 6.8'
ruby_version: 2.5.5
# SRCH-1253
# - build:
# name: 'ruby 2.5, ES 7.7'
# ruby_version: 2.5.5
# elasticsearch_version: 7.7.0
- build:
name: 'ruby 2.6, ES 6.8'
ruby_version: 2.6.6
- build:
name: 'ruby 2.7, ES 6.8'
ruby_version: 2.7.0
name: "Ruby << matrix.ruby_version >>, ES << matrix.elasticsearch_version >>"
matrix:
parameters:
ruby_version:
- 2.6.6
- 2.7.3
elasticsearch_version:
- 6.8.15

0 comments on commit 816fec4

Please sign in to comment.