Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary reflection #24

Merged
merged 1 commit into from
Nov 16, 2024
Merged

Remove unnecessary reflection #24

merged 1 commit into from
Nov 16, 2024

Conversation

Alexdoru
Copy link
Member

It's just reflecting classes that are within the same mod

@Dream-Master Dream-Master requested a review from a team November 15, 2024 11:58
Copy link
Member

@glowredman glowredman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please cache the result of Loader.isModLoaded().

Have you checked if the game doesn't crash now if NEI is not installed?

@Alexdoru
Copy link
Member Author

Alexdoru commented Nov 15, 2024

Please cache the result of Loader.isModLoaded().

No I won't there is no point.
Can we stop automatically saying "can you cache the isModLoaded call" everytime there is one ? It makes sense if it is called often in a code "hotspot" but here it is called once when the game starts and then it is called one time when you press a Waila keybind. Caching such a call would make 0 effect on performance.

Have you checked if the game doesn't crash now if NEI is not installed?

It does indeed work when NEI is not present.

@Dream-Master Dream-Master merged commit 0f9710a into master Nov 16, 2024
1 check passed
@Dream-Master Dream-Master deleted the reflection branch November 16, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants