✨ feat(quantity): add a function is_any_quantity checking isinstance(x, AbstractQuantity) #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #354 +/- ##
=======================================
Coverage 97.76% 97.76%
=======================================
Files 44 44
Lines 1609 1611 +2
Branches 315 315
=======================================
+ Hits 1573 1575 +2
Misses 29 29
Partials 7 7 ☔ View full report in Codecov by Sentry. |
|
See https://github.com/GalacticDynamics/coordinax/blob/3a1e79929ac7d89fc64c18b77d5a419ed79942f0/src/coordinax/_src/utils.py#L145 and its uses in coordinax. |
|
Ping @adrn @jnibauer. |
nstarman
force-pushed
the
quantity/is_quantity
branch
from
225df5b to
37602ac
Compare
…x, AbstractQuantity) This is useful for type checking, and also for jax.tree is_leaf filtering. Signed-off-by: Nathaniel Starkman <[email protected]>
nstarman
force-pushed
the
quantity/is_quantity
branch
from
37602ac to
52456b6
Compare
adrn
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for jax.tree is_leaf filtering.