Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 build(benchmarks): add more benchmarks and config #363

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

nstarman
Copy link
Contributor

@nstarman nstarman commented Jan 8, 2025

Backporting because there are no direct API changes. The bump to matplotlib support is 🤷.

@nstarman nstarman added the backport v1.0.x on-merge: backport to versions/v1.0.x label Jan 8, 2025
@nstarman nstarman added this to the v1.0.x milestone Jan 8, 2025
@nstarman nstarman marked this pull request as ready for review January 8, 2025 16:22
@nstarman nstarman merged commit a9e0afb into GalacticDynamics:main Jan 8, 2025
21 checks passed
@nstarman nstarman deleted the tests/fix-benchmarks branch January 8, 2025 16:22
meeseeksmachine pushed a commit to meeseeksmachine/unxt that referenced this pull request Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.76%. Comparing base (aefd9d4) to head (9d3d51f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #363   +/-   ##
=======================================
  Coverage   97.76%   97.76%           
=======================================
  Files          44       44           
  Lines        1609     1609           
  Branches      327      315   -12     
=======================================
  Hits         1573     1573           
  Misses         29       29           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jan 8, 2025

CodSpeed Performance Report

Merging #363 will improve performances by 19.78%

Comparing nstarman:tests/fix-benchmarks (9d3d51f) with main (aefd9d4)

Summary

⚡ 164 improvements
🆕 69 new benchmarks
⁉️ 21 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main nstarman:tests/fix-benchmarks Change
⁉️ test_dimension[args0] 217.7 µs N/A N/A
⁉️ test_dimension[args1] 167.4 µs N/A N/A
⁉️ test_dimension_execute[args0] 189 µs N/A N/A
⁉️ test_dimension_execute[args1] 189.5 µs N/A N/A
⁉️ test_dimension_of[args0] 706.7 µs N/A N/A
⁉️ test_dimension_of[args1] 712.5 µs N/A N/A
⁉️ test_dimension_of[args2] 1.2 ms N/A N/A
⁉️ test_dimension_of[args3] 3.8 ms N/A N/A
⁉️ test_dimension_of_execute[args0] 669.2 µs N/A N/A
⁉️ test_dimension_of_execute[args1] 729.8 µs N/A N/A
⁉️ test_dimension_of_execute[args2] 1.3 ms N/A N/A
⁉️ test_dimension_of_execute[args3] 246.3 µs N/A N/A
⁉️ test_dimension_of_jit_compile[args0] 14.7 ms N/A N/A
🆕 test_dimension[('length',)] N/A 197.5 µs N/A
🆕 test_dimension[(PhysicalType('length'),)] N/A 210.9 µs N/A
🆕 test_dimension_execute[('length',)] N/A 1 ms N/A
🆕 test_dimension_execute[(PhysicalType('length'),)] N/A 1.1 ms N/A
🆕 test_dimension_jit_compile[('length',)] N/A 2.8 ms N/A
🆕 test_dimension_jit_compile[(PhysicalType('length'),)] N/A 2.8 ms N/A
🆕 test_dimension_of[(2,)] N/A 287.7 µs N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

nstarman added a commit that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport v1.0.x on-merge: backport to versions/v1.0.x run-benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant