👽️ external(quaxed): use new quaxed.experimental.arrayish module #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #370 +/- ##
==========================================
- Coverage 97.77% 97.48% -0.29%
==========================================
Files 45 45
Lines 1617 1593 -24
Branches 315 317 +2
==========================================
- Hits 1581 1553 -28
- Misses 29 33 +4
Partials 7 7 ☔ View full report in Codecov by Sentry. |
nstarman
force-pushed
the
quantity/update-quaxed
branch
from
35ffff1 to
a6f2bac
Compare
Signed-off-by: Nathaniel Starkman <[email protected]>
nstarman
force-pushed
the
quantity/update-quaxed
branch
from
a6f2bac to
1090114
Compare
|
Approved in Zoom meeting Jan 22, 2025. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
quaxed.experimental.arrayishprovides building blocks for constructing array-ish objects. After that the primitives need to be registered.This PR refactors Quantity to use these blocks.
Since we vendor
quaxed, using the experimental module is alright. The problems in that module — typing and lax — aren't impactful here.