Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ refactor(units): consolidate abstracts #374

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

nstarman
Copy link
Contributor

No description provided.

@nstarman nstarman added this to the v1.0.x milestone Jan 23, 2025
@nstarman nstarman marked this pull request as ready for review January 23, 2025 02:40
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.48%. Comparing base (9b6b495) to head (af6720e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #374      +/-   ##
==========================================
- Coverage   97.48%   97.48%   -0.01%     
==========================================
  Files          45       45              
  Lines        1593     1591       -2     
  Branches      317      316       -1     
==========================================
- Hits         1553     1551       -2     
  Misses         33       33              
  Partials        7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nstarman nstarman merged commit 53cdf12 into GalacticDynamics:main Jan 23, 2025
22 checks passed
@nstarman nstarman deleted the units/api branch January 23, 2025 02:46
@nstarman nstarman added the backport v1.0.x on-merge: backport to versions/v1.0.x label Jan 23, 2025
@nstarman
Copy link
Contributor Author

@meeseeksdev backport to versions/v1.0.x

Copy link

lumberbot-app bot commented Jan 23, 2025

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout versions/v1.0.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 53cdf12fc5ebaace4e4378a1e224eaf096bd6fc2
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #374: ♻️ refactor(units): consolidate abstracts'
  1. Push to a named branch:
git push YOURFORK versions/v1.0.x:auto-backport-of-pr-374-on-versions/v1.0.x
  1. Create a PR against branch versions/v1.0.x, I would have named this PR:

"Backport PR #374 on branch versions/v1.0.x (♻️ refactor(units): consolidate abstracts)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

nstarman added a commit to nstarman/unxt that referenced this pull request Jan 23, 2025
(cherry picked from commit 53cdf12)
Signed-off-by: Nathaniel Starkman <[email protected]>
nstarman added a commit that referenced this pull request Jan 23, 2025
(cherry picked from commit 53cdf12)
Signed-off-by: Nathaniel Starkman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport v1.0.x on-merge: backport to versions/v1.0.x Still Needs Manual Backport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant