Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error when using sni and setting server_hostname manually in remote #2482

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

peace-maker
Copy link
Member

Prevents silently replacing the server_hostname that was provided in ssl_args.

Fixes #2425

…n `remote`

Prevents silently replacing the `server_hostname` that was provided in `ssl_args`.

Fixes Gallopsled#2425
@peace-maker peace-maker merged commit a3b22b7 into Gallopsled:dev Oct 24, 2024
9 of 10 checks passed
@peace-maker peace-maker deleted the remote_sni branch October 24, 2024 13:56
peace-maker added a commit to peace-maker/pwntools that referenced this pull request Oct 26, 2024
…n `remote` (Gallopsled#2482)

* Throw error when using `sni` and setting `server_hostname` manually in `remote`

Prevents silently replacing the `server_hostname` that was provided in `ssl_args`.

Fixes Gallopsled#2425

* Update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remote should not overwrite server_hostname
1 participant