Test Python version >= 3.10 in CI and fix tests on Python 3.12 #2486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peace-maker
force-pushed
the
bump_ci_python_version
branch
10 times, most recently
from
d931461
to
bd0a982
Compare
Some workflows were using 3.8 still. Start testing on 3.12 too.
`ubuntu-latest` now points to 24.04 which requires the --break-system-packages dance.
Ubuntu 24.04 dropped the python2.7 packages.
peace-maker
force-pushed
the
bump_ci_python_version
branch
from
bd0a982
to
2908adf
Compare
peace-maker
changed the title
peace-maker
force-pushed
the
bump_ci_python_version
branch
from
4bcf20b
to
f832df7
Compare
It used to print "; 0x4" but changed to "@ 0x4" in some version.
Ubuntu 24.04 seemed to have switched the qemu-user --help output to show `/usr/gnemul/qemu-$ARCH` instead of `/etc/qemu-binfmt`. Ignore the actual path in the test.
The alphabet was using `\` escape sequences badly. <stdin>:1: SyntaxWarning: invalid escape sequence '\]'
qemu throws a SIGBUS error when the shellcode tries to access unaligned memory since some version. Align the "stack" properly.
The __repr__ output of OrderedDict was changed to look like ordinary {} dicts.
There is a 151 RESUME opcode in Python 3.12 now.
Python 3.11 added a sanity check to argparse to prevent registering the same subparser multiple times. argparse.ArgumentError: argument command: conflicting subparser: cyclic Avoid importing the command twice. `python -m pwnlib.commandline.cyclic` failed on Python 3.11 triggered in CI when running the commandline tools while collecting coverage.
peace-maker
added a commit
to peace-maker/pwntools
that referenced
this pull request
Oct 26, 2024
…psled#2486) * Bump tested python version to >= 3.10 Some workflows were using 3.8 still. Start testing on 3.12 too. * Fix installing rpyc in CI on ubuntu 24.04 `ubuntu-latest` now points to 24.04 which requires the --break-system-packages dance. * Test Python 2 on Ubuntu 22.04 Ubuntu 24.04 dropped the python2.7 packages. * Test on android-34 * Fix ARM binutils disassembly output test expectation It used to print "; 0x4" but changed to "@ 0x4" in some version. * Skip QEMU LD_PREFIX path test Ubuntu 24.04 seemed to have switched the qemu-user --help output to show `/usr/gnemul/qemu-$ARCH` instead of `/etc/qemu-binfmt`. Ignore the actual path in the test. * Fix x86 ascii shellcode encoder test The alphabet was using `\` escape sequences badly. <stdin>:1: SyntaxWarning: invalid escape sequence '\]' * Fix mips xor encoder unaligned memory access qemu throws a SIGBUS error when the shellcode tries to access unaligned memory since some version. Align the "stack" properly. * Fix util.lists.partition test output on Python 3.12 The __repr__ output of OrderedDict was changed to look like ordinary {} dicts. * Fix safeeval test on Python 3.12 There is a 151 RESUME opcode in Python 3.12 now. * Fix registering commandline subparsers multiple times for Python 3.11 Python 3.11 added a sanity check to argparse to prevent registering the same subparser multiple times. argparse.ArgumentError: argument command: conflicting subparser: cyclic Avoid importing the command twice. `python -m pwnlib.commandline.cyclic` failed on Python 3.11 triggered in CI when running the commandline tools while collecting coverage. * Fix pip cache in CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some workflows were using 3.8 still. Start testing on 3.12 too.
ubuntu-latestnow points to 24.04 which requires the --break-system-packages dance when installing pip packages globally. Fix installing rpyc in CI too.This revealed a bunch of regressions in the tests for Python 3.12.