Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various CI breakages caused by crucible-debug and TypeRepr-related changes #1303

Merged
merged 3 commits into from
Feb 11, 2025
Merged

Fix various CI breakages caused by crucible-debug and TypeRepr-related changes #1303

merged 3 commits into from
Feb 11, 2025

Conversation

RyanGlScott
Copy link
Contributor

Fixes #1302.

@RyanGlScott
Docker images: Ensure crucible-{debug,syntax} is copied over
31a59e4 
This fixed an oversight from #1297 in which `crux` gained additional
`crucible-debug` and `crucble-syntax` dependencies, but these dependencies were
not reflected in the `crux-llvm` or `crux-mir` Docker images. Easily fixed.

Towards a fix for #1302.
@RyanGlScott
crucible-debug: Accept new test output due to changes in TypeRepr pre…
ae3d6dd 
…tty-printing

This fixes an oversight from #1295 in which the `Pretty` instance for
`TypeRepr` was changed, but the expected test output from various
`crucible-debug` test cases (which depend on the behavior of that `Pretty`
instance) were not updated. Easily fixed.

Towards a fix for #1302.
@RyanGlScott
uc-crux-llvm: Define debug option in test suite
6f66b5c 
The `debug` option was introduced in #1297, but due to an oversight, this
option was not defined in the `uc-crux-llvm` test suite. Easily fixed.

Towards a fix for #1302.
@RyanGlScott RyanGlScott force-pushed the T1302-crucible-debug-ci-fixes branch from 15d2327 to 6f66b5c Compare February 11, 2025 13:02
@RyanGlScott
Copy link
Contributor Author

Successful Docker image jobs demonstrating that these changes work:

langston-barrett
langston-barrett approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@langston-barrett langston-barrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching these!

@RyanGlScott RyanGlScott merged commit 850f88f into master Feb 11, 2025
47 checks passed
@RyanGlScott RyanGlScott deleted the T1302-crucible-debug-ci-fixes branch February 11, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langston-barrett langston-barrett langston-barrett approved these changes

@kquick kquick Awaiting requested review from kquick

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assorted CI errors due to crucible-debug-related changes
2 participants
@RyanGlScott @langston-barrett