Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create bplus db skeleton and reserve db module #35

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

BnjmnZmmrmn
Copy link

created skeleton for bplus backed database implementation (NOT the bplus tree implementation) and added to list of db modules

@BnjmnZmmrmn BnjmnZmmrmn added the feature New feature or request label Sep 11, 2024
@BnjmnZmmrmn BnjmnZmmrmn self-assigned this Sep 11, 2024
@BnjmnZmmrmn BnjmnZmmrmn linked an issue Sep 11, 2024 that may be closed by this pull request
@maxfierrog maxfierrog linked an issue Sep 11, 2024 that may be closed by this pull request
Copy link
Member

@maxfierrog maxfierrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

//! This module provides a database implementation backed by a
//! persistent bplus tree.
//!
//! #### Authorship
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to leave it in if you want, but I kinda removed all of the authorship tags from all files (already in dev).

I first did it because I saw it in Classic, and I figured I should do it too. But there is git blame nowadays, so there is really no need. Still, feel free to leave it in if you want to, it's nice in its own right to be people-first in that regard.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont really care for it either, i was just modelling after other files in src/database/~. also its not about individual contributions, but about project progress 😸

src/database/bplus/mod.rs Show resolved Hide resolved
@BnjmnZmmrmn BnjmnZmmrmn merged commit 961480f into GamesCrafters:dev-bplusdb Sep 11, 2024
@BnjmnZmmrmn BnjmnZmmrmn added this to the persistent database backed by bplus tree milestone Sep 13, 2024
@BnjmnZmmrmn BnjmnZmmrmn added this to the v1.0.0 release milestone Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants