Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resized card-imgs of our features section #330

Merged
merged 2 commits into from
Oct 6, 2024
Merged

resized card-imgs of our features section #330

merged 2 commits into from
Oct 6, 2024

Conversation

Palmistry2310
Copy link
Contributor

@Palmistry2310 Palmistry2310 commented Oct 6, 2024

Issues Identification

Closes: #286

Description

Adjusted image size for better visibility in 'our features' section.

Summary

This pull request addresses the issue of small image sizes in the "Our Features" section. The images are currently too small, resulting in poor visibility and a diminished user experience. The image sizes have been adjusted to fit better within the card layout, providing clearer visuals.

Details

The following modifications have been made:

  • Increased the dimensions of the images displayed in the feature cards to enhance visibility.
  • Ensured that the images maintain their aspect ratio when resized to prevent distortion.
  • Added appropriate CSS rules to ensure consistent padding and margins around the images for better layout aesthetics.

Types of Changes

Please check the boxes that apply:

  • Bugfix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that introduces new functionality)
  • Breaking change (modification that may cause existing functionality to not work as expected)
  • Documentation update (changes to documentation content)
  • Other (please specify): enhanced the visibility of the images in our features section.

Checklist

Please ensure the following criteria are met:

  • My code adheres to the project's style guidelines
  • I have conducted a self-review of my code
  • I have commented my code, especially in complex areas
  • I have updated the documentation to reflect my changes
  • My changes do not introduce new warnings
  • My changes maintain the current system's functionality and pass all existing test cases
  • I have added tests to verify the effectiveness of my fix or feature
  • All new and existing unit tests pass locally with my changes

Screenshots

Before:
image in card
After:
updates feature section

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Palmistry2310, for creating this pull request and contributing to Resum-Resume! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@GarimaSingh0109 GarimaSingh0109 merged commit b0effeb into GarimaSingh0109:main Oct 6, 2024
@Palmistry2310
Copy link
Contributor Author

Palmistry2310 commented Oct 6, 2024

may you please add the labels? @GarimaSingh0109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Our Features section : Images in cards are too Small – Adjust Image Size for Better Visibility.
2 participants