Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: use static registry key to check vcredist on x86 Windows installer #2474

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −2
Open

Fix: use static registry key to check vcredist on x86 Windows installer #2474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6778a5
Fix: use static registry key to check vcredist on x86 Windows installer
SpecterShell Mar 18, 2024
caed4ff
Also fix win7- installer
SpecterShell Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion BuildTools/windows/installer/32bit/GeoDa-win7+.iss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ end;

function VCRedistNeedsInstall: Boolean;
begin
Result := not RegKeyExists(HKLM,'SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\{03d1453c-7d5c-479c-afea-8482f406e036}');
Result := not RegKeyExists(HKLM,'SOFTWARE\Microsoft\VisualStudio\14.0\VC\Runtimes\X86');
end;

function GetUninstallString: string;
Expand Down
2 changes: 1 addition & 1 deletion BuildTools/windows/installer/32bit/GeoDa.iss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ end;

function VCRedistNeedsInstall: Boolean;
begin
Result := not RegKeyExists(HKLM,'SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\{03d1453c-7d5c-479c-afea-8482f406e036}');
Result := not RegKeyExists(HKLM,'SOFTWARE\Microsoft\VisualStudio\14.0\VC\Runtimes\X86');
end;

function GetUninstallString: string;
Expand Down
Loading