Fix Asserts and typos #835
Conversation
There was a problem hiding this comment.
Thanks for finding and fixing this! I am supprised that this is not tested (I guess because the lines are technically "covered").
Could you fix the failing tests (update the message in the log)?
tests/gwb-grid/grid_help.log
tests/gwb-grid/grid_non_existing_wb.log
Thanks!
|
Sure! I fixed the tests by hand, as I couldn't find a changediff artifact to download and apply. Is there such a thing produced by the tester? |
|
Thanks for fixing it. The remaining issue had to with some of the postprocessing of the results, to get rid of run specific info (for example, number of threads, run paths, etc.). I pushed a commit which fixes that.
Unfortunately not yet. It has been on my todo list to add since the hack. It might not be much work, so I will give it a go :) |
|
@anne-glerum See #837 |
I ran into some Asserts when converting a 3D .grid file into a 2D one. There were some inconstistencies in the Asserts checking the number of grid cells in each direction and some typos that this PR fixes.