Switch to profi200s dsi sd card driver #160
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds changes to switch from using libnds DSi SD card driver to profi200 SD card driver from here, partially fixes #71
The driver was slightly modified to use libtwl instead, and it waits for an event instead of just halting, thanks to @XLuma as libtwl integration is based from his implementation in another libtwl related project.
This has been tested working correctly in both DSi/3DS consoles, with these SD cards;
It also fixes random flickering in Mega Man Zero 4 intro stage BG animations and Wild Battle Encounter animation intros in Pokémon games, it may also fix other SD related issues in other games.
Sound crackling is still occurring in some games, like Mermaid Melody, so that may require to implement NDMA into this driver.