Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed error when clicking the 'View changes' button on a resource edi… #275

Open
wants to merge 2 commits into
base: 7.x-1.x
Choose a base branch
from
Open

Fixed error when clicking the 'View changes' button on a resource edi… #275

wants to merge 2 commits into from

Conversation

achraf-jeday
Copy link
Contributor

@achraf-jeday achraf-jeday commented Sep 29, 2016 •
edited
Loading

Ref https://github.com/NuCivic/wbddh/issues/377

Steps to Reproduce

  1. - On any resource, click 'Edit'
  2. - Make a change to any field
  3. - Click 'View Changes'

A new resource is created with the changes. The original resource is unaltered, and there is no normal 'view changes' dialog.

@dafeder dafeder mentioned this pull request Oct 3, 2016
Merged
@janette
Copy link
Member

janette commented Oct 6, 2016 •
edited
Loading

screencapture-192-168-99-100-32811-node-7-edit-1475782268557

@janette janette mentioned this pull request Oct 7, 2016
Merged
4 tasks
@janette
Copy link
Member

janette commented Oct 7, 2016 •
edited
Loading

  1. we loose the file object from the upload field
  2. tests should fail, so we need a test for 'view changes'
  3. check what happened here: https://github.com/NuCivic/dkan_dataset/pull/276/files
  4. Ignore what the image says about buttons, the buttons are the correct resource form buttons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achraf-jeday @janette